james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tellier Benoit (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JSIEVE-94) Nullpointer in SieveMailAdapter#post()
Date Thu, 07 Jan 2016 13:37:39 GMT

    [ https://issues.apache.org/jira/browse/JSIEVE-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087357#comment-15087357
] 

Tellier Benoit commented on JSIEVE-94:
--------------------------------------

After reading the RFC-5429 :

 The only change to the reject action are :

" Clarified that the "reject" action cancels the implicit keep.
   Extended the list of allowable actions on "reject" to include
   protocol-level message rejection."

 - I will write tests on keep cancelation
 - Due to James design, we can not add reject at the protocol level

And to answer Eike Kettner problem :

"Note that according to [MDN], Message Disposition Notifications MUST
   NOT be generated if the MAIL FROM (or Return-Path) is empty."

Null sender might be logged, but actions shall not be taken.

> Nullpointer in SieveMailAdapter#post()
> --------------------------------------
>
>                 Key: JSIEVE-94
>                 URL: https://issues.apache.org/jira/browse/JSIEVE-94
>             Project: James jSieve
>          Issue Type: Bug
>          Components: JSieve (Main)
>    Affects Versions: 0.5
>            Reporter: Eike Kettner
>
> I've got a NPE when using the reject action with a simple sieve script:
> require ["reject"];
> if header :matches "From" ["*john@*"] {
>   reject "Don't want your mail.";
> }
> The class `SieveMailAdapter` implements the `post()` Method declared in `ActionContext`.
The method's api doc says, that the `sender` argument may be null. In that respect the line
134 in `RejectAction` is ok, since it passes `null` to the `post()` method. The implementation
of that method however, delegates this null argument to the `sendMail()` method of `MailetContext`
(`JamesMailetContext` l.413). The api doc here does not tell whether null is allowed or not,
but if sender is null, it would fail in `ToSenderFolder#doService()` (l.90). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message