james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Lysenkov <lysen...@silvertreesystems.com>
Subject Re: Sub-addressing support in JAMES
Date Thu, 28 Apr 2016 15:56:13 GMT
Hello,

Thank you for your help.

I have done patch. Please see in attachment.



On Thu, Apr 28, 2016 at 6:17 PM, Ioan Eugen Stan <stan.ieugen@gmail.com>
wrote:

> Hello,
>
> Usually github is a read only git mirror of Apache repositories. Meaning
> you can't push, especially since you are not a committer.
>
> Read more here [1].
>
> What you should do is either:
>
> 1. work on your clone and create a patch with git patch , submit via email
> 2. fork project on github, push your branch on your fork and issue a
> pull request, then send email to list with PR.
>
> Any branch name is fine.
>
>
> [1] http://www.apache.org/dev/git.html
>
> On 28.04.2016 17:57, Sergey Lysenkov wrote:
> > Hello Antoine,
> >
> > Thank you for your reply.
> > I faced out with problem. I can't push code to repository on
> > https://github.com/apache/james-project
> >
> > I have got error:
> > remote: Permission to apache/james-project.git denied to lysenkovsts.
> > fatal: unable to access 'https://github.com/apache/james-project.git/':
> The
> > requested URL returned error: 403
> >
> > Can you help me to resolve this issue?
> >
> > Also I don't know what branch name will be correct for my code. On my
> local
> > repository I named branch as JAMES-subaddressing. What do you think about
> > that branch name?
> >
> > On Thu, Apr 28, 2016 at 3:57 PM, Antoine DUPRAT <aduprat@linagora.com>
> > wrote:
> >
> >> Hi,
> >>
> >> Thank you for using James.
> >> We are really happy to receive contribution, you can create a pull
> request
> >> on GitHub:
> >> https://github.com/apache/james-project
> >>
> >> Have a nice day,
> >> Antoine Duprat
> >>
> >>
> >> Hello All,
> >>>
> >>> Our team successfuly used James mail server for a project untile we've
> got
> >>> a requirement to support sub-addressing. It turned out that James does
> not
> >>> support a tag appended to the local part of email address (ex:
> >>> joeuser+tag@example.com). RFC 5233, refers to this convention as
> >>> sub-addressing, but it is also known as plus addressing or tagged
> >>> addressing. To resolve this issue our team have developed
> >>> 'SubAddressingValidRcptHandler' which extends from
> >>> 'org.apache.james.smtpserver.fastfail.ValidRcptHandler' class. Also to
> >>> find
> >>> the right addressee by email address with sub-addressing we have
> developed
> >>> matcher 'SubAddressingMatcher'.
> >>>
> >>> I do not know if you have plans to implement the sub-addressing
> support. I
> >>> can send you our code for review and will be happy if our changes save
> >>> time
> >>> for other developers who faced with the same issue as we had.
> >>>
> >>> Please let me know if that makes sense and which way I can send the
> code
> >>> for review.
> >>>
> >>> Thank you,
> >>> Sergey Lysenkov
> >>>
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> >> For additional commands, e-mail: server-dev-help@james.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>

Mime
View raw message