james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Lee (JIRA)" <server-...@james.apache.org>
Subject [jira] [Created] (JAMES-1808) if (character > 128) should be changed to if (character >= 128)
Date Mon, 25 Jul 2016 00:41:20 GMT
Paul Lee created JAMES-1808:
-------------------------------

             Summary: if (character > 128) should be changed to if (character >= 128)
                 Key: JAMES-1808
                 URL: https://issues.apache.org/jira/browse/JAMES-1808
             Project: James Server
          Issue Type: Bug
          Components: IMAPServer
    Affects Versions: 3.0.0-beta5
            Reporter: Paul Lee
            Priority: Minor
             Fix For: 3.0.0-beta5


There is a conditional code block as follows in the class 'ImapResponseComposerImpl' of the
package 'org.apache.james.imap.encode.base' in the 'protocols-imap' project.
            // 7-bit ASCII only
            if (character > 128) {
                buffer.write(BYTE_QUESTION);
            } else {
                buffer.write((byte) character);
            }

An equals(=) sign should be included in the conditional since the range of US-ASCII is from
0 to 127(not including 128).





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message