james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adup...@apache.org
Subject [02/12] james-project git commit: JAMES-1862 Remove TODO note on commons-net fix
Date Tue, 06 Dec 2016 12:25:20 GMT
JAMES-1862 Remove TODO note on commons-net fix


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/8633537d
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/8633537d
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/8633537d

Branch: refs/heads/master
Commit: 8633537d9c82f15c155c9ec36201e7144b3bb223
Parents: 76f9d61
Author: Antoine Duprat <aduprat@apache.org>
Authored: Wed Nov 30 10:04:30 2016 +0100
Committer: Antoine Duprat <aduprat@apache.org>
Committed: Thu Dec 1 14:17:02 2016 +0100

----------------------------------------------------------------------
 .../james/protocols/smtp/AbstractStartTlsSMTPServerTest.java  | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/8633537d/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/AbstractStartTlsSMTPServerTest.java
----------------------------------------------------------------------
diff --git a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/AbstractStartTlsSMTPServerTest.java
b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/AbstractStartTlsSMTPServerTest.java
index 626cb17..02f87ec 100644
--- a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/AbstractStartTlsSMTPServerTest.java
+++ b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/AbstractStartTlsSMTPServerTest.java
@@ -97,11 +97,8 @@ public abstract class AbstractStartTlsSMTPServerTest {
             
             assertTrue(client.execTLS());
             
-            // TODO: Add back once commons-net 3.1.0 was released.
-            // See: NET-421
-            //
-            //client.quit();
-            //assertTrue("Reply="+ client.getReplyString(), SMTPReply.isPositiveCompletion(client.getReplyCode()));
+            client.quit();
+            assertTrue("Reply="+ client.getReplyString(), SMTPReply.isPositiveCompletion(client.getReplyCode()));
             
             client.disconnect();
 


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message