james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adup...@apache.org
Subject [27/34] james-project git commit: JAMES-2085 Remove other useless TODOs
Date Wed, 05 Jul 2017 13:59:34 GMT
JAMES-2085 Remove other useless TODOs


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/8a888769
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/8a888769
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/8a888769

Branch: refs/heads/master
Commit: 8a88876981ffc43a00751532ded1ad77a8502964
Parents: 2a8be11
Author: benwa <btellier@linagora.com>
Authored: Mon Jul 3 16:32:02 2017 +0700
Committer: benwa <btellier@linagora.com>
Committed: Wed Jul 5 17:13:48 2017 +0700

----------------------------------------------------------------------
 .../james/mailbox/jpa/migrator/JpaMigratorTest.java    | 13 +++++--------
 .../apache/james/imap/api/message/MessageFlags.java    |  2 +-
 .../methods/integration/cucumber/DownloadStepdefs.java |  2 --
 3 files changed, 6 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/8a888769/mailbox/tool/src/test/java/org/apache/james/mailbox/jpa/migrator/JpaMigratorTest.java
----------------------------------------------------------------------
diff --git a/mailbox/tool/src/test/java/org/apache/james/mailbox/jpa/migrator/JpaMigratorTest.java
b/mailbox/tool/src/test/java/org/apache/james/mailbox/jpa/migrator/JpaMigratorTest.java
index b3de9cb..bd47945 100644
--- a/mailbox/tool/src/test/java/org/apache/james/mailbox/jpa/migrator/JpaMigratorTest.java
+++ b/mailbox/tool/src/test/java/org/apache/james/mailbox/jpa/migrator/JpaMigratorTest.java
@@ -21,38 +21,35 @@ package org.apache.james.mailbox.jpa.migrator;
 import org.junit.Ignore;
 import org.junit.Test;
 
-// TODO
 @Ignore("This class needs to be reviewed")
 public class JpaMigratorTest {
-
     @Test
     public void testImap165() throws Exception {
         JpaMigrator.main(new String[]{"IMAP165"});
     }
 
-    @Test()
+    @Test
     public void testImap168() throws Exception {
         JpaMigrator.main(new String[]{"IMAP168"});
     }
 
-    @Test()
+    @Test
     public void testImap172() throws Exception {
         JpaMigrator.main(new String[]{"IMAP172"});
     }
 
-    @Test()
+    @Test
     public void testImap176() throws Exception {
         JpaMigrator.main(new String[]{"IMAP176"});
     }
 
-    @Test()
+    @Test
     public void testImap180() throws Exception {
         JpaMigrator.main(new String[]{"IMAP180"});
     }
 
-    @Test()
+    @Test
     public void testImap184() throws Exception {
         JpaMigrator.main(new String[]{"IMAP184"});
     }
-
 }

http://git-wip-us.apache.org/repos/asf/james-project/blob/8a888769/protocols/imap/src/main/java/org/apache/james/imap/api/message/MessageFlags.java
----------------------------------------------------------------------
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/api/message/MessageFlags.java
b/protocols/imap/src/main/java/org/apache/james/imap/api/message/MessageFlags.java
index 3466a43..2a890c0 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/api/message/MessageFlags.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/api/message/MessageFlags.java
@@ -26,7 +26,7 @@ import java.util.Collections;
 import javax.mail.Flags;
 
 /**
- * The set of flags associated with a message. TODO - why not use
+ * The set of flags associated with a message.
  * javax.mail.Flags instead of having our own.
  * 
  * <p>

http://git-wip-us.apache.org/repos/asf/james-project/blob/8a888769/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
index 68ba2ae..a60506a 100644
--- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
+++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
@@ -103,8 +103,6 @@ public class DownloadStepdefs {
                 ClassLoader.getSystemResourceAsStream("eml/oneInlinedImage.eml"), new Date(),
false, new Flags());
         
         attachmentsByMessageId.put(messageId, attachmentId);
-        // TODO
-        //blobIdByAttachmentId.put(attachmentId, "<correctComputedBlobId>");
     }
 
     @Given("^\"([^\"]*)\" mailbox \"([^\"]*)\" contains a message \"([^\"]*)\" with multiple
same inlined attachments \"([^\"]*)\"$")


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message