james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-992) Limit max line length for protocol when using Netty
Date Mon, 02 Oct 2017 12:16:05 GMT

    [ https://issues.apache.org/jira/browse/JAMES-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187919#comment-16187919
] 

ASF GitHub Bot commented on JAMES-992:
--------------------------------------

Github user chibenwa commented on a diff in the pull request:

    https://github.com/apache/james-project/pull/73#discussion_r142121913
  
    --- Diff: mailet/standard/src/main/java/org/apache/james/transport/matchers/HasMimeType.java
---
    @@ -0,0 +1,74 @@
    +/****************************************************************
    + * Licensed to the Apache Software Foundation (ASF) under one   *
    + * or more contributor license agreements.  See the NOTICE file *
    + * distributed with this work for additional information        *
    + * regarding copyright ownership.  The ASF licenses this file   *
    + * to you under the Apache License, Version 2.0 (the            *
    + * "License"); you may not use this file except in compliance   *
    + * with the License.  You may obtain a copy of the License at   *
    + *                                                              *
    + *   http://www.apache.org/licenses/LICENSE-2.0                 *
    + *                                                              *
    + * Unless required by applicable law or agreed to in writing,   *
    + * software distributed under the License is distributed on an  *
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
    + * KIND, either express or implied.  See the License for the    *
    + * specific language governing permissions and limitations      *
    + * under the License.                                           *
    + ****************************************************************/
    +
    +
    +package org.apache.james.transport.matchers;
    +
    +import com.google.common.base.Splitter;
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.collect.ImmutableSet;
    +import org.apache.james.core.MailAddress;
    +import org.apache.mailet.Mail;
    +import org.apache.mailet.base.GenericMatcher;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import javax.activation.MimeType;
    +import javax.activation.MimeTypeParseException;
    +import javax.mail.MessagingException;
    +import javax.mail.internet.MimeMessage;
    +import java.util.Collection;
    +import java.util.Optional;
    +import java.util.Set;
    +
    +
    +/**
    + * <p>This matcher checks if the content type matches.</p>
    + *
    + * use: <pre><code><mailet match="HasMimeType=text/plain,text/html" class="..."
/></code></pre>
    + */
    +public class HasMimeType extends GenericMatcher {
    +
    +    private static final Logger LOGGER = LoggerFactory.getLogger(HasHabeasWarrantMark.class);
    +
    +    private Set<String> acceptedContentTypes;
    +
    +    public void init() throws javax.mail.MessagingException {
    +        acceptedContentTypes = ImmutableSet.copyOf(Splitter.on(",").trimResults().split(getCondition()));
    +    }
    +
    +    public Collection<MailAddress> match(Mail mail) throws javax.mail.MessagingException
{
    +        Optional<String> mimeTypes = getMimeTypeFromMessage(mail.getMessage());
    +
    +        return mimeTypes.filter(acceptedContentTypes::contains)
    +                .map(any -> mail.getRecipients())
    +                .orElse(ImmutableList.of());
    +    }
    +
    +    private static Optional<String> getMimeTypeFromMessage(MimeMessage message)
throws MessagingException {
    +        try {
    +            return Optional.of(new MimeType(message.getContentType()).getBaseType());
    +        } catch (MimeTypeParseException e) {
    +            LOGGER.warn(e.toString());
    --- End diff --
    
    Ah, I missed this one.
    
    My big concern here is that "we loose the stacktrace", which makes understanding and categorizing
possible errors harder.
    
    We should add an error message explaining what's happening ("Error while checking message
mimeType") and pass the exception as a second argument.


> Limit max line length for protocol when using Netty
> ---------------------------------------------------
>
>                 Key: JAMES-992
>                 URL: https://issues.apache.org/jira/browse/JAMES-992
>             Project: James Server
>          Issue Type: Improvement
>            Reporter: Norman Maurer
>             Fix For: 3.0-M1
>
>
> We should limit the max characters per line so nobody can cause OOM when doing a DOS
attach



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message