james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-2199) Improve usage of SLF4J
Date Fri, 08 Dec 2017 07:25:00 GMT

    [ https://issues.apache.org/jira/browse/JAMES-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283153#comment-16283153
] 

ASF GitHub Bot commented on JAMES-2199:
---------------------------------------

Github user chibenwa commented on the issue:

    https://github.com/apache/james-project/pull/76
  
    I started a new build against your branch in https://github.com/linagora/james-project/pull/1176
    
    PS: We have the habit to prefix commit message with the ticket number:
    
    ```
    JAMES-2199 My awesome fix about logging
    ```
    
    I reworded your commits on the `slf4j-related-fixes` of my repository.


> Improve usage of SLF4J
> ----------------------
>
>                 Key: JAMES-2199
>                 URL: https://issues.apache.org/jira/browse/JAMES-2199
>             Project: James Server
>          Issue Type: Improvement
>            Reporter: Daniel Trebbien
>            Priority: Minor
>
> As suggested in the SLF4J FAQ (see [https://www.slf4j.org/faq.html#logging_performance])
parameterized logging can improve the efficiency of logger calls when logging at the specified
level is disabled.
> When a value is formatted, toString() is called automatically: [https://www.slf4j.org/faq.html#string_contents]
> In addition, there are some cases where a format string has incorrect syntax, or not
enough format args are passed. This can lead to loss of data in the logs.
> There are some other cases where the result of String.format() or a string buffer/builder
are passed to a logger call. Parameterized logging can be used even when an extra exception/throwable
should be logged: [https://www.slf4j.org/faq.html#paramException]
> James Project uses SLF4J 1.7.25, which is affected by a regression introduced in SLF4J
1.7.15. See: [http://mailman.qos.ch/pipermail/slf4j-user/2017-August/001639.html]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message