james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-2275) Allow per Exception error handling in the mailet pipeline
Date Tue, 09 Jan 2018 07:56:00 GMT

    [ https://issues.apache.org/jira/browse/JAMES-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317953#comment-16317953
] 

ASF GitHub Bot commented on JAMES-2275:
---------------------------------------

Github user mbaechler commented on a diff in the pull request:

    https://github.com/apache/james-project/pull/96#discussion_r160337122
  
    --- Diff: server/mailet/mailetcontainer-camel/src/test/java/org/apache/james/mailetcontainer/lib/AbstractStateMailetProcessorTest.java
---
    @@ -198,6 +200,7 @@ public void afterMailet(Mailet m, String mailName, String state, long
processTim
     
             // the source mail should have state error as the exception was thrown
             assertEquals(Mail.ERROR, mail.getState());
    +        assertEquals(MessagingException.class, mail.getAttribute(Mail.MAILET_ERROR_ATTRIBUTE_NAME));
    --- End diff --
    
    this assertions does not belong to this test because as the test name says : "matcher
Processing Should Not Result In An Exception When Matcher Throws" but not "matcher processing
should capture exception as an email attribute".
    
    Would you mind adding a new test for that ?


> Allow per Exception error handling in the mailet pipeline
> ---------------------------------------------------------
>
>                 Key: JAMES-2275
>                 URL: https://issues.apache.org/jira/browse/JAMES-2275
>             Project: James Server
>          Issue Type: New Feature
>          Components: Mailet Contributions
>    Affects Versions: master
>            Reporter: Tellier Benoit
>              Labels: easy-fix, feature, newbie
>
> In JAMES-2271 from [~apptaro], the error handling system of the mailet pipeline can now
be customized using the *onMailetException* property. This allows specifying the processor
for error handling or ignore the error (by default error processor is triggered).
> While empowering the user to write custom error handling logic, the error handling code
capabilities is limited as the original exception is lost along the way.
> We should:
>  - Pass the Exception along with the Mail, as an attribute. 
> Thus mailet in the error processor can access and read it. Throwable being serializable,
this makes this change easy to perform.
>  - Implement specific error handling matchers:
>    - *HasException* would allow to see if a Mail has a specific exception
> {code:xml}
> <mailet match="HasException=org.apache.james.managesieve.api.ManageSieveException"
class="...>
>     ....
> </mailet>
> {code}
> ### How to implement this
> 1. Add a ERROR_ATTRIBUTE_NAME contant in the Mail interface
> 2. ProcessorUtil:: handleException should add the ERROR_ATTRIBUTE_NAME attriute using
the provided exception
> 3. Modify *AbstractStateMailetProcessorTest* to demonstrate that when a mailet or a matcher
throws, the Exception is attahed to the incoming mail.
> 4. In the mailet/standard project, you will implement the HasException matcher. You can
extend GenericMatcher and implement unit tests for your class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message