james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-2330) Give ability to override AbstractConfigurableAsyncServer.buildSSLContext
Date Mon, 05 Feb 2018 18:51:00 GMT

    [ https://issues.apache.org/jira/browse/JAMES-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352766#comment-16352766

ASF GitHub Bot commented on JAMES-2330:

Github user randymo commented on a diff in the pull request:

    --- Diff: server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/netty/AbstractConfigurableAsyncServer.java
    @@ -104,7 +104,7 @@
         private String secret;
    -    private Encryption encryption;
    +    protected Encryption encryption;
    --- End diff --
    the buildSSLContext() needs to be able to set the Encryption, without a way to set that
field (protected or with setter), the overriding class would need to hold that variable to
return it, and you would have to override the getEncryption(). I was thinking that getEncryption()
would just need to be overridden in rare cases and the overridden buildSSLContext() would
be the usual way of doing it.

> Give ability to override AbstractConfigurableAsyncServer.buildSSLContext
> ------------------------------------------------------------------------
>                 Key: JAMES-2330
>                 URL: https://issues.apache.org/jira/browse/JAMES-2330
>             Project: James Server
>          Issue Type: Bug
>          Components: SMTPServer
>    Affects Versions: 3.0.1
>            Reporter: Randal Modowski
>            Priority: Major
>              Labels: easyfix
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> I was trying to have my smtp server be able to serve different certs to user based on
remote ip, but couldn't the way james is curretly.
> I am creating a PR to make buildSSLContext protect as well as the Encryption field
itself. Also making all reference to Encryption use the getEncryption() in case someone wants
to override that call as well.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

View raw message