james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackie issa <jackie.i...@hotmail.com>
Subject Re: [jira] [Commented] (JAMES-2382) Inconsistent method name
Date Tue, 24 Apr 2018 07:00:53 GMT
Hi 

Sent from my iPhone

> On Apr 24, 2018, at 9:27 AM, ASF GitHub Bot (JIRA) <server-dev@james.apache.org>
wrote:
> 
> 
>    [ https://issues.apache.org/jira/browse/JAMES-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449369#comment-16449369
] 
> 
> ASF GitHub Bot commented on JAMES-2382:
> ---------------------------------------
> 
> Github user BruceKuiLiu commented on the issue:
> 
>    https://github.com/apache/james-project/pull/110
> 
>    Thanks.
>    How about now?
> 
> 
>> Inconsistent method name
>> ------------------------
>> 
>>                Key: JAMES-2382
>>                URL: https://issues.apache.org/jira/browse/JAMES-2382
>>            Project: James Server
>>         Issue Type: Improvement
>>           Reporter: KuiLIU
>>           Priority: Major
>> 
>> The following method is named "hasAnnotatedProperty" that is a query of asking whether
the propertyDescriptor has the AnnotatedProperty or not.
>> Actually, the method returns an AnnotatedProperty found by the propertyDescriptor.
>> Thus, the method name "findAnnotatedProperty" should be intuitive than "hasAnnotatedProperty".
>> {code:java}
>>    private A hasAnnotatedProperty(PropertyDescriptor propertyDescriptor) {
>>        Method setter = propertyDescriptor.getWriteMethod();
>>        return setter != null ? AnnotationUtils.getAnnotation(setter, getAnnotation())
: null;
>>    }
>> {code}
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message