james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "KuiLIU (JIRA)" <server-...@james.apache.org>
Subject [jira] [Created] (JAMES-2382) Inconsistent method name
Date Sat, 21 Apr 2018 22:10:00 GMT
KuiLIU created JAMES-2382:

             Summary: Inconsistent method name
                 Key: JAMES-2382
                 URL: https://issues.apache.org/jira/browse/JAMES-2382
             Project: James Server
          Issue Type: Improvement
            Reporter: KuiLIU

The following method is named "hasAnnotatedProperty" that is a query of asking whether the
propertyDescriptor has the AnnotatedProperty or not.
Actually, the method returns an AnnotatedProperty found by the propertyDescriptor.
Thus, the method name "findAnnotatedProperty" should be intuitive than "hasAnnotatedProperty".

    private A hasAnnotatedProperty(PropertyDescriptor propertyDescriptor) {
        Method setter = propertyDescriptor.getWriteMethod();
        return setter != null ? AnnotationUtils.getAnnotation(setter, getAnnotation()) : null;

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

View raw message