james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-2382) Inconsistent method name
Date Tue, 24 Apr 2018 03:12:00 GMT

    [ https://issues.apache.org/jira/browse/JAMES-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449218#comment-16449218
] 

ASF GitHub Bot commented on JAMES-2382:
---------------------------------------

Github user chibenwa commented on the issue:

    https://github.com/apache/james-project/pull/110
  
    Hi.
    
    Thanks for this naming fix. 
    
    A little remark: we tend to prefix the commit message with the ticket number (to make
code searches easier). In your case that might be:
    
    ```
    JAMES-2382 Change the method name.
    ```
    
    Can you rebase and reword your commit?
    
    Cheers,
    
    Benoit


> Inconsistent method name
> ------------------------
>
>                 Key: JAMES-2382
>                 URL: https://issues.apache.org/jira/browse/JAMES-2382
>             Project: James Server
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named "hasAnnotatedProperty" that is a query of asking whether
the propertyDescriptor has the AnnotatedProperty or not.
> Actually, the method returns an AnnotatedProperty found by the propertyDescriptor.
> Thus, the method name "findAnnotatedProperty" should be intuitive than "hasAnnotatedProperty".
> {code:java}
>     private A hasAnnotatedProperty(PropertyDescriptor propertyDescriptor) {
>         Method setter = propertyDescriptor.getWriteMethod();
>         return setter != null ? AnnotationUtils.getAnnotation(setter, getAnnotation())
: null;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message