james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTOCOLS-118) Continuation Response can't handle Login
Date Mon, 14 May 2018 18:39:00 GMT

    [ https://issues.apache.org/jira/browse/PROTOCOLS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474601#comment-16474601
] 

ASF GitHub Bot commented on PROTOCOLS-118:
------------------------------------------

GitHub user Flyffies opened a pull request:

    https://github.com/apache/james-project/pull/115

    PROTOCOLS-118 Continuation Response can't handle Login

    It seems James does not handle the repeated continuation request correctly.
    
    This is the first part of the fix.
    NGINX for example is expecting some text after the initial continuation Tag ("+").
    Changed it so an "+ Ok" is send.
    It seems to be specified by the RFC 3501, though it is a very vague description.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Flyffies/james-project master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/james-project/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 5ae946aef4894d970a95985c9edf804244ae59d2
Author: Flyffies <flyffies@...>
Date:   2018-05-14T18:15:46Z

    Fixed continuation request not getting recognised by some clients

commit 76fd4e5b4fab55e2d9193d819f08d0d0024b7d50
Author: Flyffies <flyffies@...>
Date:   2018-05-14T18:34:46Z

    Added comments to the changes

----


> Continuation Response can't handle Login
> ----------------------------------------
>
>                 Key: PROTOCOLS-118
>                 URL: https://issues.apache.org/jira/browse/PROTOCOLS-118
>             Project: James Protocols
>          Issue Type: Bug
>          Components: imap
>    Affects Versions: 1.6.3
>         Environment: Docker
>            Reporter: Marc
>            Assignee: Eric Charles
>            Priority: Major
>
> I was testing with the NGINX Imap Proxy and notices the login just times out.
> The first and Major issue is that the login is split into multiple requests.
> The expected communication from NGINX is the following:
> C -> N: 1 login testUser testPass
> N -> J: 1 login {8}
> J -> N: + Ok
> N -> J: testUser {8}
> J -> N: + Ok
> N -> J: testPass
> J -> N: 1 Ok...
> N -> C: 1 Ok...
> It seems James does not handle the repeated continuation request correctly.
> NGINX is expecting some text after the initial continuation Tag ("+").
> I Submitted a PR to github for that. Changed it so an "+ Ok" is send.
> It seems to be specified by the [RFC 3501|https://tools.ietf.org/html/rfc3501#page-79],
though it is a very vague description. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message