james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTOCOLS-118) Continuation Response can't handle Login
Date Tue, 15 May 2018 02:41:00 GMT

    [ https://issues.apache.org/jira/browse/PROTOCOLS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475212#comment-16475212

ASF GitHub Bot commented on PROTOCOLS-118:

Github user chibenwa commented on the issue:

    Hi @Flyffies ,
    Thank you for the contribution, it is an interesting one!
    I had a quick look, and this seems like a good move. I will be launching some integration
tests on this.
    I just have two little comments:
     - We tend to prefix commit messages with the JIRA tickets. Here:
    PROTOCOLS-118 Fixed continuation request not getting recognised by some clients
     - We tend to avoid comments in the code. These comments can be moved as part of the commit
message if needed.
    Benoit Tellier

> Continuation Response can't handle Login
> ----------------------------------------
>                 Key: PROTOCOLS-118
>                 URL: https://issues.apache.org/jira/browse/PROTOCOLS-118
>             Project: James Protocols
>          Issue Type: Bug
>          Components: imap
>    Affects Versions: 1.6.3
>         Environment: Docker
>            Reporter: Marc
>            Assignee: Eric Charles
>            Priority: Major
> I was testing with the NGINX Imap Proxy and notices the login just times out.
> The first and Major issue is that the login is split into multiple requests.
> The expected communication from NGINX is the following:
> C -> N: 1 login testUser testPass
> N -> J: 1 login {8}
> J -> N: + Ok
> N -> J: testUser {8}
> J -> N: + Ok
> N -> J: testPass
> J -> N: 1 Ok...
> N -> C: 1 Ok...
> It seems James does not handle the repeated continuation request correctly.
> NGINX is expecting some text after the initial continuation Tag ("+").
> I Submitted a PR to github for that. Changed it so an "+ Ok" is send.
> It seems to be specified by the [RFC 3501|https://tools.ietf.org/html/rfc3501#page-79],
though it is a very vague description. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

View raw message