james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-2295) JMS mailqueue deadlock when a single thread issue several consume
Date Wed, 11 Jul 2018 06:10:00 GMT

    [ https://issues.apache.org/jira/browse/JAMES-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539602#comment-16539602
] 

ASF GitHub Bot commented on JAMES-2295:
---------------------------------------

Github user chibenwa commented on a diff in the pull request:

    https://github.com/apache/james-project/pull/127#discussion_r201572188
  
    --- Diff: server/queue/queue-api/src/main/java/org/apache/james/queue/api/MailQueue.java
---
    @@ -128,4 +128,24 @@ public MailQueueException(String msg) {
              */
             void done(boolean success) throws MailQueueException;
         }
    +
    +    /**
    +     * Provides additional options when creating consumers.
    +     */
    +    interface ConsumerOptions {
    --- End diff --
    
    I'm globally against such genericity.
    
    Specific configuration options should be specified on a per mail queue implementation
basis.
    
    I would suggest to keep this specific for ActiveMQ (or JMS if it makes sens).


> JMS mailqueue deadlock when a single thread issue several consume
> -----------------------------------------------------------------
>
>                 Key: JAMES-2295
>                 URL: https://issues.apache.org/jira/browse/JAMES-2295
>             Project: James Server
>          Issue Type: Bug
>          Components: Queue
>    Affects Versions: 3.0.0, master, 3.0.1
>            Reporter: Tellier Benoit
>            Priority: Major
>              Labels: bug
>
> This will lead to a dead lock:
> {code:java}
>         MailQueue.MailQueueItem mailQueueItem1 = getMailQueue().deQueue();
>         MailQueue.MailQueueItem mailQueueItem2 = getMailQueue().deQueue();
>         mailQueueItem1.done(true);
>         mailQueueItem2.done(true);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message