james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-2298) FileMailQueue do not support remove
Date Tue, 06 Nov 2018 02:28:00 GMT

    [ https://issues.apache.org/jira/browse/JAMES-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676046#comment-16676046
] 

ASF GitHub Bot commented on JAMES-2298:
---------------------------------------

Github user chibenwa commented on a diff in the pull request:

    https://github.com/apache/james-project/pull/129#discussion_r230979896
  
    --- Diff: server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java
---
    @@ -62,34 +79,40 @@
     /**
      * {@link ManageableMailQueue} implementation which use the fs to store {@link Mail}'s
      * <p/>
    - * On create of the {@link FileMailQueue} the {@link #init()} will get called. This takes
care of
    - * loading the needed meta-data into memory for fast access.
    + * On create of the {@link FileMailQueue} the {@link #init()} will get called. This takes
care of loading the needed
    + * meta-data into memory for fast access.
      */
     public class FileMailQueue implements ManageableMailQueue {
    +    private static final String FILE_PATH_KEY = "key";
    +    private static final Set<String> FIELDS_TO_LOAD = Collections.singleton(FILE_PATH_KEY);
         private static final Logger LOGGER = LoggerFactory.getLogger(FileMailQueue.class);
    +    private static final AtomicLong COUNTER = new AtomicLong();
    --- End diff --
    
    Sorry, I also miss good knowledge about this class internals...


> FileMailQueue do not support remove
> -----------------------------------
>
>                 Key: JAMES-2298
>                 URL: https://issues.apache.org/jira/browse/JAMES-2298
>             Project: James Server
>          Issue Type: Bug
>          Components: Queue
>    Affects Versions: master
>            Reporter: Tellier Benoit
>            Priority: Major
>
> An exception is thrown or the code badly modify the state of the queue



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message