james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <server-...@james.apache.org>
Subject [jira] [Commented] (JAMES-2657) SSLEngine and SslHandler unaware of remote ip and port
Date Wed, 06 Feb 2019 09:19:00 GMT

    [ https://issues.apache.org/jira/browse/JAMES-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761603#comment-16761603
] 

ASF GitHub Bot commented on JAMES-2657:
---------------------------------------

Github user mbaechler commented on the issue:

    https://github.com/apache/james-project/pull/148
  
    Hi @randymo  and thank you for this contribution.
    I see that you also opened a JIRA about that and that's great.
    To be honest, I don't understand the problem you described, could you elaborate on behavior
you need ?
    Talking about this PR, I have two concerns about it:
    * it's quite a lot of code duplication, it could probably be solved by abstracting a bit
the SSL API.
    * as it doesn't come with tests, we can't guarantee it won't break in the future.
    
    I know that tests are hard, even more when we speak about SSL but maybe writing a couple
of integration tests would help for both the code maintenance and the understanding of your
problem. WDYT ?


> SSLEngine and SslHandler unaware of remote ip and port
> ------------------------------------------------------
>
>                 Key: JAMES-2657
>                 URL: https://issues.apache.org/jira/browse/JAMES-2657
>             Project: James Server
>          Issue Type: Bug
>            Reporter: Randymo
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Our team uses the remote ip of the connect to determine the ssl cert we use for the connection.
We had to make changes on our end to make that accessible to us at the level we needed it.
It would be nice if James did this automatically itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message