james-server-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rene Cordier (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MAILBOX-382) EventDeadLetter: rechedule event delivery
Date Tue, 26 Feb 2019 08:21:00 GMT

    [ https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777715#comment-16777715
] 

Rene Cordier edited comment on MAILBOX-382 at 2/26/19 8:20 AM:
---------------------------------------------------------------

Hmmm now that you said it... You are probably right.

However those already exist in REST webadmin, raising the same issue : 

{code:java}
GET /events/deadLetter/groups
GET /events/deadLetter/groups/:group/events
GET /events/deadLetter/groups/:group/events/:eventId
DELETE /events/deadLetter/groups/:group/events/:eventId
{code}

Might need to refactor the all REST interface for dead letters... I was thinking, because
we need events for refining some operations to some event id, might be better to get rid of
the first 'events' occurence, so that the root base would be '/deadLetter/' instead of '/events/deadLetter',
like for example :

{code:java}
curl -POST /deadLetter/events?action=reDeliver
{code}

WDYT?


was (Author: rcordier):
Hmmm now that you said it... You are probably right.

However those already exist in REST webadmin : 

{code:java}
GET /events/deadLetter/groups
GET /events/deadLetter/groups/:group/events
GET /events/deadLetter/groups/:group/events/:eventId
DELETE /events/deadLetter/groups/:group/events/:eventId
{code}

Might need to refactor the all REST interface for dead letters... I was thinking, because
we need events for refining some operations to some event id, might be better to get rid of
the first 'events' occurence, so that the root base would be '/deadLetter/' instead of '/events/deadLetter',
like for example :

{code:java}
curl -POST /deadLetter/events?action=reDeliver
{code}

WDYT?

> EventDeadLetter: rechedule event delivery
> -----------------------------------------
>
>                 Key: MAILBOX-382
>                 URL: https://issues.apache.org/jira/browse/MAILBOX-382
>             Project: James Mailbox
>          Issue Type: New Feature
>            Reporter: Trần Tiến Đức
>            Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono<Void> reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Mime
View raw message