jclouds-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds] JCLOUDS-127 (#32)
Date Mon, 17 Jun 2013 13:03:06 GMT
>     public void addToClose(Closeable toClose) {
>        methodsToClose.add(toClose);
>     }
>  
>     public void close() throws IOException {
> -      Collections.reverse(methodsToClose);
> -      for (Closeable toClose : methodsToClose) {
> -         toClose.close();
> +      if (state.compareAndSet(State.OPEN, State.CLOSING)) {

Tricky, I agree. I think after seeing the various review comments we can say that if it passes
all the tests, we should be OK with this change. Once it's committed perhaps an email to the
user@ list might not be a bad idea.

@nacx What do you think?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/32/files#r4723366

Mime
  • Unnamed multipart/alternative (inline, 7-Bit, 0 bytes)
View raw message