jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TangYong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCLOUDS-85) Avoid creating uneeded instance of PropertyShellTableFactory
Date Tue, 02 Jul 2013 09:34:20 GMT

    [ https://issues.apache.org/jira/browse/JCLOUDS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13697633#comment-13697633

TangYong commented on JCLOUDS-85:

I have pulled a request : https://github.com/jclouds/jclouds-karaf/pull/18

Fixing has passed my local basic test.
> Avoid creating uneeded instance of PropertyShellTableFactory
> ------------------------------------------------------------
>                 Key: JCLOUDS-85
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-85
>             Project: jclouds
>          Issue Type: Improvement
>          Components: jclouds-karaf
>    Affects Versions: 1.7.0, 1.6.1, 1.5.11
>            Reporter: Ioannis Canellos
> The story here is that we have 2 versions of the ShellTableFactory:
> i) OSGi aware
> ii) Property based
> Our commands always instantiate (ii) and may replace it with (i) when running inside
> We should make sure that we instantiate (ii) only if no injection takes place (e.g. outside
> This could be as simple as checking if the factory is null inside the doExecute method
and then instantiating (ii).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message