jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francis Devereux (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCLOUDS-410) Convert InputSupplier<InputStream> methods to ByteSource
Date Fri, 17 Jan 2014 10:33:30 GMT

    [ https://issues.apache.org/jira/browse/JCLOUDS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874640#comment-13874640
] 

Francis Devereux commented on JCLOUDS-410:
------------------------------------------

My previous comment isn't correct - the new version is OK, because jclouds doesn't actually
call ByteSource.read(), it uses ByteSource.openStream() instead which doesn't try to read
the whole file into memory.

> Convert InputSupplier<InputStream> methods to ByteSource
> --------------------------------------------------------
>
>                 Key: JCLOUDS-410
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-410
>             Project: jclouds
>          Issue Type: Improvement
>          Components: jclouds-blobstore, jclouds-core
>    Affects Versions: 1.7.0
>            Reporter: Andrew Gaul
>            Assignee: Andrew Gaul
>             Fix For: 1.8.0
>
>
> ByteSource has convenience methods and avoids generics notational overhead.  Guava is
moving towards this:
>     
> https://groups.google.com/forum/#!msg/guava-discuss/bChfnnXb9QA/xlmy2UzsmpsJ
> Note that ByteSource implements InputSupplier<InputStream> so we should retain
source compatibility.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message