jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)
Date Wed, 05 Feb 2014 18:06:39 GMT
> @@ -56,7 +57,7 @@ public FirewallOptions addAllowedRule(Firewall.Rule allowedRule) {
>     /**
>      * @see org.jclouds.googlecomputeengine.domain.Firewall#getAllowed()
>      */
> -   public FirewallOptions allowedRules(Set<Firewall.Rule> allowedRules) {
> +   public FirewallOptions allowedRules(List<Firewall.Rule> allowedRules) {

This was an attempt, that I forgot to remove, sorry @demobox
I agree `Set` is better here, but there is a unit test testCreateNodeWhenNetworkNorFirewallExistDoesNotExist
which fails randomly because of the order of the rules when I use Set. Any suggestions?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20/files#r9470867
Mime
View raw message