jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)
Date Wed, 05 Feb 2014 19:02:06 GMT
> +import static com.google.common.base.Preconditions.checkState;
> +import static com.google.common.collect.Iterables.contains;
> +import static com.google.common.collect.Iterables.filter;
> +import static com.google.common.collect.Iterables.transform;
> +import static com.google.common.collect.Iterables.tryFind;
> +import static java.util.concurrent.TimeUnit.MILLISECONDS;
> +import static org.jclouds.googlecomputeengine.GoogleComputeEngineConstants.CENTOS_PROJECT;
> +import static org.jclouds.googlecomputeengine.GoogleComputeEngineConstants.DEBIAN_PROJECT;
> +import static org.jclouds.googlecomputeengine.GoogleComputeEngineConstants.GCE_BOOT_DISK_SUFFIX;
> +import static org.jclouds.googlecomputeengine.GoogleComputeEngineConstants.GCE_DELETE_BOOT_DISK_METADATA_KEY;
> +import static org.jclouds.googlecomputeengine.GoogleComputeEngineConstants.GCE_IMAGE_METADATA_KEY;
> +import static org.jclouds.googlecomputeengine.GoogleComputeEngineConstants.OPERATION_COMPLETE_INTERVAL;
> +import static org.jclouds.googlecomputeengine.GoogleComputeEngineConstants.OPERATION_COMPLETE_TIMEOUT;
> +import static org.jclouds.googlecomputeengine.domain.Instance.NetworkInterface.AccessConfig.Type;
> +import static org.jclouds.googlecomputeengine.predicates.InstancePredicates.isBootDisk;
> +import static org.jclouds.util.Predicates2.retry;

Not bad, but it makes the diff unnecessarily big. It would be nice if it could be avoided,
but I don't think we need to manually fix the PR for this.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20/files#r9473122
Mime
View raw message