jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds] JCLOUDS-450. Adding support for EC2 MaxCount option. (#277)
Date Wed, 05 Feb 2014 18:38:40 GMT
> @@ -122,6 +131,10 @@ public ToStringHelper string() {
>        ImmutableSet<BlockDeviceMapping> mappings = blockDeviceMappings.build();
>        if (mappings.size() != 0)
>           toString.add("blockDeviceMappings", mappings);
> +      if (maxCount != null)

> Yeah, it's a bit confusing - maxCount is an Integer, but getMaxCount() returns an int.

I think you may have seen the old version of my comment ;-) I was asking not about null, but
about possible negative values here. What if someone sets this to -10?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/277/files#r9472128
Mime
View raw message