jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)
Date Tue, 11 Mar 2014 14:25:34 GMT
The builds look good, which is nice. Only one small comment about the method name. Some questions:

* Is the default behaviour backwards-compatible, or are we changing default behaviour with
this commit? If so, do we need to document to users how to maintain backwards-compatible behaviour
if they wish?
* Do we need a test to verify that the new logic works as expected? Or does the "launchCluster"
test cover that case?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20#issuecomment-37300854
Mime
View raw message