jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)
Date Tue, 11 Mar 2014 14:22:59 GMT
>      * @see org.jclouds.googlecomputeengine.features.FirewallApi#patch(String, org.jclouds.googlecomputeengine.options.FirewallOptions)
>      */
> -   private void getOrCreateFirewalls(GoogleComputeEngineTemplateOptions templateOptions,
Network network,
> -                                     FirewallTagNamingConvention naming) {
> -
> +   private void getAndPatchOrCreateFirewalls(GoogleComputeEngineTemplateOptions templateOptions,
Network network,

Could we replace "Patch" with "Update" or "Modify" here? I always associate "Patch" with some
kind of temporary fix ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20/files#r10474592
Mime
View raw message