jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)
Date Tue, 18 Mar 2014 20:31:31 GMT
> +                  try {
> +                     HttpRequest negotiationRequest = HttpRequest.builder()
> +                        .method("GET").endpoint(baseEndpointUri)
> +                        .addHeader(VERSION_NEGOTIATION_HEADER, "true").build();
> +                     InputStream response = client.invoke(negotiationRequest).getPayload().openStream();
> +                     VersionsJsonResponse versions = json.fromJson(Strings2.toStringAndClose(response),
VersionsJsonResponse.class);
> +                     for( VersionsJsonResponse.Version version : versions.versions )
{
> +                        if(apiVersion.equals(version.id)) {
> +                           String newURIString = version.links.get(0).href;
> +                           if(newURIString.startsWith("http:") && baseEndpointUri.toString().startsWith("https:"))
> +                              newURIString = "https" + newURIString.substring(4);
> +                           versionEndpointUri = new URI(newURIString);
> +                           break;
> +                        }
> +                     }
> +                  } catch (Exception ex) {

What Exceptions are we catching here? Why do we need this catch block, and can we catch a
narrower exception?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/82/files#r10724045
Mime
View raw message