jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds] Refactor SoftLayer CCI support (#296)
Date Wed, 05 Mar 2014 13:36:48 GMT
> +import org.jclouds.softlayer.domain.VirtualGuest;
> +import org.jclouds.softlayer.domain.VirtualGuestBlockDevice;
> +
> +import javax.inject.Inject;
> +import java.util.HashSet;
> +import java.util.Set;
> +
> +import static com.google.common.base.Preconditions.checkNotNull;
> +
> +/**
> + * Converts a VirtualGuest into a json string valid for creating a CCI via softlayer
api
> + * The string is set into the payload of the HttpRequest
> + * 
> + * @author Andrea Turli
> + */
> +public class VirtualGuestToJson implements Binder {

I agree with you but in the jclouds philosophy I think VirtualGuestApi should reflect the
signature of the REST api [createObject](http://sldn.softlayer.com/reference/services/SoftLayer_Virtual_Guest/createObject)
so in other words it needs to get the SoftLayer_Virtual_Guest object that you wish to create.

I'm not particular happy of this design decision done at SoftLayer but I think it is what
it is.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r10298946
Mime
View raw message