jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds] Add nova neutron support (#311)
Date Sat, 08 Mar 2014 19:55:53 GMT
> @@ -218,8 +221,19 @@ private ServerRequest(String name, String imageRef, String flavorRef)
{
>  
>        if (!networks.isEmpty()) {
>           server.networks = Sets.newLinkedHashSet(); // ensures ordering is preserved
- helps testing and more intuitive for users.
> -         for (String network : networks) {
> -            server.networks.add(ImmutableMap.of("uuid", network));
> +         for (Network network : networks) {
> +            // Avoid serializing null values, which are common here.
> +            Map<String, String> networkMap = Maps.newHashMap();

Use ImmutableMap.builder()?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/311/files#r10410845
Mime
View raw message