jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds] JCLOUDS-184: Improving AzureBlob unit tests for AzureBlobBlockUploadStrategyTest (#320)
Date Wed, 19 Mar 2014 00:01:04 GMT
> @@ -70,5 +65,29 @@ public void testExecute() throws Exception {
>        replay(slicer,client);
>        String etag = strat.execute(container, blob);
>        assertEquals(etag, "Fake ETAG");
> +
> +      verify(slicer, client);
> +   }
> +
> +   @Test(groups = "unit", expectedExceptions = IllegalArgumentException.class)
> +   public void testExceededContentLengthLimit() throws Exception {
> +      String container = "test-container";
> +      String blobName = "test-blob";
> +
> +      AzureBlobClient client = createMock(AzureBlobClient.class);
> +      PayloadSlicer slicer = createMock(PayloadSlicer.class);

Don't we at least need to call `replay` on the mocks? And, since we're not actually expecting
any behaviour, create nice mocks instead?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/320/files#r10732060
Mime
View raw message