jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-aws] Added some fixes to the live test and a few things on the rest of the co... (#5)
Date Tue, 03 Jun 2014 04:08:48 GMT
> @@ -34,7 +37,7 @@
>  
>     @Override
>     public void validate(String vaultName) {
> -      if (vaultName == null || vaultName.length() < MIN_LENGTH || vaultName.length()
> MAX_LENGTH)
> +      if (isNullOrEmpty(vaultName) || vaultName.length() > MAX_LENGTH)
>           throw exception(vaultName, "Can't be null or empty. Length must be " + MIN_LENGTH
+ " to " + MAX_LENGTH

This is now a little tricky: we are still using a MIN_LENGTH value that could be changed,
but are not checking it in the condition. Change the message to `"Length must be 0 to " +
MAX_LENGTH` or `"Length must be <= " + MAX_LENGTH + " but was " + vaultName.length() +
"(vault name: " + vaultName + ")` or so?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/5/files#r13318409
Mime
View raw message