jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rahulruikar <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-569 : Storage for jobs is changed to list of maps (#67)
Date Mon, 02 Jun 2014 07:54:07 GMT
Hi Ignasi,

I am done resolving all review comments except one.
I am facing some problem modifying CloudSigma2ApiExpectTest#testGetDriveInfo
<https://github.com/jclouds/jclouds-labs/blob/master/cloudsigma2/src/test/ja
va/org/jclouds/cloudsigma2/CloudSigma2ApiExpectTest.java#L203>

I am seeing same problem even while working on master branch. I am not sure
whether I am missing out on something.

Problem :
   testGetDriveInfo(), testGetServerInfo(), testGetPricing() etc.. Currently
these tests are checed against result object Š assertNotNull(result);
  If I try to get any value from these objects and compare against something
like Assert.assertEquals() then it always returns NULL

Ex. In testGetDriveInfo(), testGetDriveInfo() .. If I try to use ³uuid² and
compare it then it always says uuid is NULL.

Can you please provide some info.

Regards,
Rahul


From:  Ignasi Barrera <notifications@github.com>
Reply-To:  jclouds/jclouds-labs
<reply+i-34539993-ea0a85a689f78f6b2444c66fff1a87f4f98270e6-7720253@reply.git
hub.com>
Date:  Friday, May 30, 2014 at 6:36 PM
To:  jclouds/jclouds-labs <jclouds-labs@noreply.github.com>
Cc:  Rahul Ruikar <rahul.ruikar@gmail.com>
Subject:  Re: [jclouds-labs] JCLOUDS-569 : Storage for jobs is changed to
list of maps (#67)


Thanks for the changes @rahulruikar <https://github.com/rahulruikar> ! A
couple general comments to complete the pull request, apart from the
previous ones:
*  The jclouds style uses a 3 space indent (no tabs) and a 120 line length.
Could you format your code accordingly?
*  Run mvn checkstyle:checkstyle in the cloudsigma2 project and make sure
there are no checkstyle violations.
*  To properly test the change, the corresponding Expect test should be also
changed: 
> *  Modify the drives-single.json
> <https://github.com/jclouds/jclouds-labs/blob/master/cloudsigma2/src/test/reso
> urces/drives-single.json#L9>  and add some jobs there. The file contains a
> "mock" response that is used in tests to verify responses can be properly
> parsed.
> *  Modify the CloudSigma2ApiExpectTest#testGetDriveInfo
> <https://github.com/jclouds/jclouds-labs/blob/master/cloudsigma2/src/test/java
> /org/jclouds/cloudsigma2/CloudSigma2ApiExpectTest.java#L203>  test to use that
> drives-single.json (now the test is not properly configured), and add some
> assertions to the test to verify the returned object contains the jobs you
> configured in the mock json.
We're almost there! Thanks!

‹
Reply to this email directly or view it on GitHub
<https://github.com/jclouds/jclouds-labs/pull/67#issuecomment-44627135> .

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/67#issuecomment-44810307
Mime
View raw message