jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds] Add pool field to Nova FloatingIP (#385)
Date Mon, 02 Jun 2014 13:34:54 GMT
> @@ -48,8 +48,10 @@ public String resource() {
>     @SelectJson("floating_ips")
>     @Consumes(MediaType.APPLICATION_JSON)
>     public Set<FloatingIP> expected() {
> -      return ImmutableSet.of(FloatingIP.builder().id("1").instanceId("12").ip("10.0.0.3").fixedIp("11.0.0.1").build(),
> -            FloatingIP.builder().id("2").instanceId(null).ip("10.0.0.5").fixedIp(null).build());
> +      return ImmutableSet.of(
> +            FloatingIP.builder().id("1").instanceId("12").ip("10.0.0.3").fixedIp("11.0.0.1").pool("nova").build(),
> +            FloatingIP.builder().id("2").instanceId(null).ip("10.0.0.5").fixedIp(null).pool("nova").build(),
> +            FloatingIP.builder().id("3").instanceId("13").ip("10.0.0.13").fixedIp("11.0.0.3").build());

On the theme of `pool` being nullable: do we need a version with an explicit `.pool(null)`
call?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/385/files#r13284021
Mime
View raw message