jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zack Shoylev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCLOUDS-672) Automatically cleaning up orphaned nova key pairs causes exceptions
Date Fri, 15 Aug 2014 16:57:18 GMT

    [ https://issues.apache.org/jira/browse/JCLOUDS-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098751#comment-14098751
] 

Zack Shoylev commented on JCLOUDS-672:
--------------------------------------

java.lang.IllegalArgumentException: Object 'Cloud-Server' doesn't match dns naming constraints.
Reason: Should be only lowercase.
	at org.jclouds.predicates.validators.DnsNameValidator.exception(DnsNameValidator.java:74)
	at org.jclouds.predicates.validators.DnsNameValidator.validate(DnsNameValidator.java:56)
	at org.jclouds.predicates.validators.DnsNameValidator.validate(DnsNameValidator.java:36)
	at org.jclouds.compute.internal.FormatSharedNamesAndAppendUniqueStringToThoseWhichRepeat.checkGroup(FormatSharedNamesAndAppendUniqueStringToThoseWhichRepeat.java:124)
	at org.jclouds.compute.internal.FormatSharedNamesAndAppendUniqueStringToThoseWhichRepeat.containsGroup(FormatSharedNamesAndAppendUniqueStringToThoseWhichRepeat.java:152)
	at org.jclouds.openstack.nova.v2_0.compute.NovaComputeService.cleanupOrphanedKeyPairsInZone(NovaComputeService.java:156)
	at org.jclouds.openstack.nova.v2_0.compute.NovaComputeService.cleanOrphanedGroupsInZone(NovaComputeService.java:132)
	at org.jclouds.openstack.nova.v2_0.compute.NovaComputeService.cleanUpIncidentalResourcesOfDeadNodes(NovaComputeService.java:126)
	at org.jclouds.compute.internal.BaseComputeService.destroyNodesMatching(BaseComputeService.java:274)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at com.google.inject.internal.DelegatingInvocationHandler.invoke(DelegatingInvocationHandler.java:37)
	at com.sun.proxy.$Proxy58.destroyNodesMatching(Unknown Source)
	at com.sometegroup.jppf.client.servers.ServerDeletor.call(ServerDeletor.java:126)
	at com.sometegroup.jppf.client.servers.ServerDeletor.run(ServerDeletor.java:81)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

> Automatically cleaning up orphaned nova key pairs causes exceptions
> -------------------------------------------------------------------
>
>                 Key: JCLOUDS-672
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-672
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-compute, jclouds-core
>    Affects Versions: 1.8.0
>            Reporter: Zack Shoylev
>            Assignee: Zack Shoylev
>
> cleanupOrphanedKeyPairsInRegion:
> https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeService.java#L156
> This uses (in containsGroup)
> https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/predicates/validators/DnsNameValidator.java
> to validate the nova key pair names. This is wrong. The API allows much more freedom
for key pair names than the DNS validator allows, causing strange exceptions for users.
> I am guessing that this most likely happens when the DNS validator is used in https://github.com/jclouds/jclouds/blob/master/compute/src/main/java/org/jclouds/compute/internal/FormatSharedNamesAndAppendUniqueStringToThoseWhichRepeat.java#L79



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message