jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-aws] JCLOUDS-457: Add list operation (#46)
Date Sat, 02 Aug 2014 14:50:38 GMT
> @@ -109,7 +125,7 @@ public boolean blobExists(String container, String key) {
>  
>     @Override
>     public String putBlob(String container, Blob blob) {
> -      return sync.uploadArchive(container, blob.getPayload(), blob.getMetadata().getName());
> +      return sync.uploadArchive(container, blob.getPayload());

> archive IDs are always the same length and are set by Amazon

In that case, would it be appropriate to document the `putBlob` methods of GlacierBlobstore
as "don't bother setting the name, as any value you set will be ignored. The returned name
is generated by Amazon" or so..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/46/files#r15729396
Mime
View raw message