jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasdeep-hundal <notificati...@github.com>
Subject Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)
Date Tue, 26 Aug 2014 23:53:45 GMT
> +            assertTrue(foundIt, "Failed to find the attachment we set in listAttachments()
> +
> +            volumeAttachmentApi.get().detachVolumeFromServer(testVolume.getId(), serverId);

Not sure I agree with that. For me this is clearer as it tests the whole fea/prevents us from
having to preserve info about the server between the tests and I think that the stack trace
should be enough to indicate where the problem is. The other tests here require volume detachment
as well.

Reply to this email directly or view it on GitHub:
View raw message