jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasdeep-hundal <notificati...@github.com>
Subject Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)
Date Fri, 29 Aug 2014 14:37:22 GMT
> +      String deviceName = null;
> +
> +      /**
> +       * @param volumeId ID of the volume within the block store that you wish to attach
> +       */
> +      public BlockDeviceMapping volumeId(String volumeId){
> +         this.volumeId = volumeId;
> +         return this;
> +      }
> +
> +      /**
> +       * @param deleteOnTermination True if this volume should be deleted when the instance
is terminated
> +       */
> +      public BlockDeviceMapping deleteOnTermination(boolean deleteOnTermination){
> +         // Nova expects this to be a string
> +         this.deleteOnTermination = deleteOnTermination ? "1" : "0";

@demobox @jdaggett Since I'm moving BlockDeviceMapping to its on class, is it now worth it
to create a custom mapping for the strings here and instead use true/false internally within
JClouds?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/326/files#r16900706
Mime
View raw message