jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Everett Toews <notificati...@github.com>
Subject Re: [jclouds] Configures Checkstyle plugin to fail build on warnings (#464)
Date Mon, 04 Aug 2014 16:49:13 GMT
I'm all for enabling the build failure. I don't think someone looking at the Checkstyle warnings
and saying fix x, y, and z warning is a good use of review time. Checkstyle should simply
fail the build. Then we know both locally and in the build that the code is clean w.r.t Checkstyle.

For this particular PR, the Checkstyle cleanups shouldn't be mixed in with the change to the
configuration. Please separate out the change to the project/pom.xml into a separate commit
or a separate PR, whichever works for you.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/464#issuecomment-51085649
Mime
View raw message