jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-google] Added Bucket Access Control with Tests (#27)
Date Wed, 17 Sep 2014 17:55:50 GMT
> +   @OAuthScopes(STORAGE_FULLCONTROL_SCOPE)
> +   @Fallback(NullOnNotFoundOr404.class)
> +   BucketAccessControls updateBucketAccessControls(@PathParam("bucket") String bucketName,

> +            @PathParam("entity") String entity, 
> +            @BinderParam(BindToJsonPayload.class) BucketAccessControls bucketAccessControls);
> +
> +   /**
> +    * Updates an ACL entry on the specified bucket.PATCH avoids sending unnecessary
data when modifying resources
> +    * 
> +    * @param bucketName
> +    *           Name of the bucket of that ACL to be created
> +    * @param entity
> +    *           The entity holding the permission. Can be user-userId, user-emailAddress,
group-groupId,
> +    *           group-emailAddress, allUsers, or allAuthenticatedUsers. In the request
body, supply a
> +    *           BucketAccessControls resource with role
> +    * @return If successful, this method returns a BucketAccessControls resource in
the response body

Remove things like "in the response body" from the Javadoc...that's an implementation detail.
Something like
```
@return the updated BucketAccessControls object
```
or so?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/27/files#r17681435
Mime
View raw message