jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-google] JCLOUDS-458: Live tests for BucketAccessControls, DefaultObjectAccessControls (#35)
Date Wed, 17 Sep 2014 18:18:30 GMT
> @@ -112,9 +111,7 @@ BucketAccessControls createBucketAccessControls(@PathParam("bucket")
String buck
>     @Consumes(MediaType.APPLICATION_JSON)
>     @Path("/b/{bucket}/acl/{entity}")
>     @OAuthScopes(STORAGE_FULLCONTROL_SCOPE)
> -   @Fallback(NullOnNotFoundOr404.class)
> -   @Nullable
> -   HttpResponse deleteBucketAccessControls(@PathParam("bucket") String bucketName, @PathParam("entity")
String entity);
> +   void deleteBucketAccessControls(@PathParam("bucket") String bucketName, @PathParam("entity")
String entity);

Should this not better return a boolean? Or what will happen if you try to delete a non-existent
bucket?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/35/files#r17682843
Mime
View raw message