jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
Date Sat, 20 Sep 2014 03:08:11 GMT
> +         } catch (HttpResponseException e) {
> +            // If DefaultObjectAccessControls operation fail, Reverse create operation
the operation.
> +            api.getBucketApi().deleteBucket(container);
> +            return false;
> +         }
> +      }
> +
> +      return bucket != null;
> +   }
> +
> +   /** Returns list of of all the objects */
> +   @Override
> +   public PageSet<? extends StorageMetadata> list(String container) {
> +      ListPage<GCSObject> gcsList = api.getObjectApi().listObjects(container);
> +      PageSet<? extends StorageMetadata> list = objectListToStorageMetadata.apply(gcsList);
> +      return list;

Do we need the duplication here? Can't we just call `return list(container, ListContainerOptions.NONE);`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17817482
Mime
View raw message