jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-openstack] Cleans up neutron code (#139)
Date Thu, 04 Sep 2014 21:55:42 GMT
> @@ -40,7 +40,7 @@ public String toString() {
>        return name;
>     }
>  
> -   /**

> was OK here, so why the change?

Originally my review comment, @jdaggett ;-) I made it because this seems like a comment for
a jclouds-dev, not something a **user** of jclouds would expect in the Javadoc.

A user-facing description would be something like "Converts a string representation to the
appropriate enum, with A, B and C special features" or so. But I don't really think we need
that?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17145229
Mime
View raw message