jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zack Shoylev <notificati...@github.com>
Subject Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)
Date Mon, 22 Sep 2014 18:17:24 GMT
@fbrouille Thanks for this PR! Overall it looks very good to me. I have a few comments, but
they all seem pretty minor.
It would also be nice if we can add some more docs to some of these enums and getters and
builder setters for users.

Some notes on structure and style differences: most of these seem like improvements to me,
and we might have to apply them to the rest of the neutron code (in a different PR).
I do like that the new stuff is in its own lbaas/v1 directories (esp the domain classes, something
we should consider doing). However, this is probably not needed under /extensions - just keep
LBaaSApi on the same directory level as say RouterApi. I am not so sure if we should do the
same for the fallbacks and functions or not: thoughts?

Reply to this email directly or view it on GitHub:
View raw message