jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)
Date Sun, 21 Sep 2014 20:49:52 GMT
> +   @Path("/vips")
> +   @SelectJson("vip")
> +   VIP createVIP(@WrapWith("vip") VIP.CreateVIP vip);
> +
> +   /**
> +    * Update a VIP.
> +    * 
> +    * @param id the id of the VIP to update.
> +    * @param vip the VIP's attributes to update.
> +    * @return a reference of the updated VIP.
> +    */
> +   @Named("vip:update")
> +   @PUT
> +   @Path("/vips/{id}")
> +   @SelectJson("vip")
> +   @Fallback(NullOnNotFoundOr404.class)

POST and PUT operations should not use 404 fallbacks as they can produce misleading results.
[JCLOUDS-691](https://issues.apache.org/jira/browse/JCLOUDS-691) is already reported to remove
the current uses of this practice, but new APIs/methods shouldn't use it. (@zack-shoylev @everett-toews
do you agree?)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/146/files#r17828087
Mime
View raw message