jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fbrouille <notificati...@github.com>
Subject Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)
Date Tue, 23 Sep 2014 09:41:44 GMT
> +   public String getName() {
> +      return name;
> +   }
> +
> +   /**
> +    * @return the description of the Pool.
> +    */
> +   @Nullable
> +   public String getDescription() {
> +      return description;
> +   }
> +
> +   /**
> +    * @return the subnet id for this Pool.
> +    */
> +   public String getSubnetId() {

- Create: CreateBuilder contructor constrains the developper to specify the subnetId. Do I
have to test parameter is not null in CreateBuilder.subnetId()? I prefer let OpenStack reply
with the appropriate error message.
- Update: subnetId cannot be modified after creation, so UpdateBuilder does not provide method
to modify it. The UpdatePool.subnetId is always null, and so subnet_id does not appear in
the request's payload (and Neutron does not expect subnet_id in PUT operation).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/146/files#r17899346
Mime
View raw message