jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)
Date Sun, 21 Sep 2014 14:56:39 GMT
> +            firewallRuleBuilder.ipProtocol(ipProtocolToFirewallIpProtocol.get(protocol));
> +         }
> +         firewallRules.add(firewallRuleBuilder.build());
> +      }
> +
> +      firewallPolicy = api.editFirewallPolicy(firewallPolicy.getUuid(),
> +            FirewallPolicy.Builder.fromFirewallPolicy(firewallPolicy).rules(firewallRules).build());
> +
> +      return firewallPolicyToSecurityGroup.apply(firewallPolicy);
> +   }
> +
> +   @Override
> +   public SecurityGroup removeIpPermission(final IpProtocol protocol, final int startPort,
final int endPort,
> +                                           Multimap<String, String> tenantIdGroupNamePairs,
Iterable<String> ipRanges,
> +                                           Iterable<String> groupIds, SecurityGroup
group) {
> +      final Set<String> ipSet = ipRanges != null ? ImmutableSet.copyOf(ipRanges)
: Sets.<String>newHashSet();

Just a question...if this can be a copy of `ipRanges`, are they really _ranges_ or simply
_IPs_. If they are IPs, rename the input variable?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/70/files#r17825938
Mime
View raw message