jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] Address FindBugs warnings (#71)
Date Mon, 01 Sep 2014 07:33:51 GMT
> @@ -189,7 +189,7 @@ public VirtualMachineTemplate getImage(final String id) {
>        return find(listImages(), new Predicate<VirtualMachineTemplate>() {
>           @Override
>           public boolean apply(VirtualMachineTemplate input) {
> -            return input.getId().equals(id);
> +            return input.getId().equals(id);  // TODO: comparing Integer with String

WTF. Didn't notice that. It would be safe to compare the integer form. The String should be
an integer as per: https://github.com/jclouds/jclouds-labs/blob/master/abiquo/src/main/java/org/jclouds/abiquo/compute/functions/VirtualMachineTemplateToImage.java#L62
Thanks for spotting this!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/71/files#r16943082
Mime
View raw message