jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Cole <notificati...@github.com>
Subject Re: [jclouds-labs-aws] JCLOUDS-750: Refactor glacier domain classes using @AutoValue (#64)
Date Thu, 30 Oct 2014 17:48:08 GMT
>  
>  /**
>   * Paginated collection used to store Job listing information.
>   */
> -public class PaginatedJobCollection extends IterableWithMarker<JobMetadata> {
> -   @SerializedName("JobList")
> -   private final Iterable<JobMetadata> jobs;
> -   @SerializedName("Marker")
> -   private final String marker;
> -
> -   @ConstructorProperties({ "JobList", "Marker" })
> -   public PaginatedJobCollection(Iterable<JobMetadata> jobs, String marker) {
> -      this.jobs = checkNotNull(jobs, "jobs");
> -      this.marker = marker;
> -   }
> +@AutoValue
> +public abstract class PaginatedJobCollection extends IterableWithMarker<JobMetadata>
{

extend ForwardingList. the withMarker stuff can be addressed at the call site (ex. blob list
converter). propagating guava where it doesn't add value only makes it easier to break compatibility.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/64/files#r19622689
Mime
View raw message