jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Cole <notificati...@github.com>
Subject Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Date Fri, 31 Oct 2014 22:24:03 GMT
> @@ -36,7 +47,14 @@ private HttpHealthCheckApi api() {
>  
>     @Test(groups = "live")
>     public void testInsertHttpHealthCheck() {
> -      assertGlobalOperationDoneSucessfully(api().insert(HTTP_HEALTH_CHECK_NAME), TIME_WAIT);
> +      HttpHealthCheckCreationOptions options = new HttpHealthCheckCreationOptions()

nit I prefer to declare HttpHealthCheckCreationOptions as a constant as opposed to making
a bunch of fields that partially describe it. Then just use that constant object in your assertions
below. ex. assertEquals(response.getName(), options.getName());

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71/files#r19697105
Mime
View raw message