jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zack Shoylev <notificati...@github.com>
Subject Re: [jclouds-labs-openstack] JCLOUDS-611: Neutron LBaaS (version 1) extension request (#146)
Date Wed, 01 Oct 2014 16:30:00 GMT
> +      /**
> +       * Provides the administrative state for this HealthMonitor's Builder.
> +       *
> +       * @return the Builder.
> +       * @see HealthMonitor#getAdminStateUp()
> +       */
> +      public ParameterizedBuilderType adminStateUp(Boolean adminStateUp) {
> +         healthMonitor.adminStateUp = adminStateUp;
> +         return self();
> +      }
> +   }
> +
> +   /**
> +    * Create builder (inheriting from Builder).
> +    */
> +   public static class CreateBuilder extends Builder<CreateBuilder> {

Always use a single builder constructor. The constructor should only take in parameters that
are required every time. All other attributes should be set by the setters.
In this case it seems CreateBuilder takes in ProbeType type, Integer delay, Integer timeout,
Integer maxRetries. Are all of these required when creating a HealthMonitor?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/146/files#r18289995
Mime
View raw message